Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patching table with pd.Timestamp values #5650

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 16, 2023

Warning: Builds on #5645

Fixes #5555

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #5650 (ccb0b8b) into main (cd1ba3d) will increase coverage by 47.57%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5650       +/-   ##
===========================================
+ Coverage   36.00%   83.58%   +47.57%     
===========================================
  Files         288      288               
  Lines       41769    41797       +28     
===========================================
+ Hits        15040    34934    +19894     
+ Misses      26729     6863    -19866     
Flag Coverage Δ
ui-tests 39.57% <13.33%> (+3.56%) ⬆️
unitexamples-tests 73.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/tests/widgets/test_tables.py 99.79% <100.00%> (+87.41%) ⬆️
panel/widgets/tables.py 88.88% <100.00%> (+38.71%) ⬆️

... and 215 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from fix_patch_non_monotonic to main October 16, 2023 13:52
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@philippjfr philippjfr merged commit 8e3e193 into main Oct 16, 2023
@philippjfr philippjfr deleted the fix_patch_timestamp branch October 16, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when patching a datetime column with a Timestamp
2 participants