Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix refreshed access_token access #5734

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

polivbr
Copy link
Contributor

@polivbr polivbr commented Oct 24, 2023

fixes #5733

@philippjfr
Copy link
Member

Thanks for catching this so quickly!

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5734 (325289a) into main (c298b1e) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5734      +/-   ##
==========================================
- Coverage   82.45%   82.32%   -0.14%     
==========================================
  Files         289      289              
  Lines       42111    42111              
==========================================
- Hits        34724    34669      -55     
- Misses       7387     7442      +55     
Flag Coverage Δ
ui-tests 38.27% <0.00%> (ø)
unitexamples-tests 73.49% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/io/state.py 70.95% <0.00%> (+0.47%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Seems like it isn't setting the OAuth secrets as part of tests. I'll merge this and then see if that's just due to this being a PR from an external contributor. Thanks again @polivbr!

@philippjfr philippjfr merged commit a5b9b52 into holoviz:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state.access_token ignores new tokens acquired from refresh
2 participants