Generalize ReactiveESM.select #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7699 +/- ##
==========================================
- Coverage 86.77% 86.77% -0.01%
==========================================
Files 346 346
Lines 52473 52489 +16
==========================================
+ Hits 45536 45545 +9
- Misses 6937 6944 +7 ☔ View full report in Codecov by Sentry. |
philippjfr
added a commit
that referenced
this pull request
Feb 12, 2025
* Generalize Viewable.select * Generalize ReactiveESM.select only * Revert Float.select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you had to be quite careful to implement the
selectmethod on custom components but since we now haveChildandChildrenparameters it is now quite straightforward to implement a generalizedselectmethod.