Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name in Minecraft Server config entry #139113

Merged

Conversation

elmurato
Copy link
Contributor

@elmurato elmurato commented Feb 23, 2025

Proposed change

CONF_NAME is removed from the config entry.
The user will now not be asked to enter a name while adding a new device.
Instead of the name (default: "Minecraft Server"), the server address will be used instead (config flow title and coordinator name).
If wanted, the user can still manually rename the device afterwards.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@elmurato

This comment was marked as resolved.

@elmurato elmurato requested a review from thecode February 23, 2025 14:54
@elmurato elmurato force-pushed the mcserver-remove-name-in-config-flow branch from 5f5b1f7 to b1d1b9d Compare February 23, 2025 15:40
@home-assistant home-assistant bot marked this pull request as draft February 24, 2025 15:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@elmurato elmurato marked this pull request as ready for review February 24, 2025 16:15
@home-assistant home-assistant bot requested a review from thecode February 24, 2025 16:15
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elmurato 👍

@thecode thecode merged commit 6047936 into home-assistant:dev Feb 24, 2025
32 checks passed
@elmurato elmurato deleted the mcserver-remove-name-in-config-flow branch February 24, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants