-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove name in Minecraft Server config entry #139113
Merged
thecode
merged 5 commits into
home-assistant:dev
from
elmurato:mcserver-remove-name-in-config-flow
Feb 24, 2025
Merged
Remove name in Minecraft Server config entry #139113
thecode
merged 5 commits into
home-assistant:dev
from
elmurato:mcserver-remove-name-in-config-flow
Feb 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
thecode
reviewed
Feb 23, 2025
This comment was marked as resolved.
This comment was marked as resolved.
5f5b1f7
to
b1d1b9d
Compare
thecode
requested changes
Feb 24, 2025
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
thecode
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elmurato 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
by-code-owner
cla-signed
code-quality
has-tests
integration: minecraft_server
Quality Scale: No score
quality-scale
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
CONF_NAME is removed from the config entry.
The user will now not be asked to enter a name while adding a new device.
Instead of the name (default: "Minecraft Server"), the server address will be used instead (config flow title and coordinator name).
If wanted, the user can still manually rename the device afterwards.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: