Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape dollars in names to prevent env-var expansion #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshbode
Copy link

@joshbode joshbode commented Oct 14, 2024

Dollars in filenames need to be escaped so they aren't interpreted as variables for expansion

image image

Having $ in filenames is something that is common in Remix (dynamic segments)

@Bekaboo
Copy link

Bekaboo commented Dec 24, 2024

Better to escape other special chars, e.g. %, \ as well using fnameescape(), see #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants