-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Play crash report mystery thread 1.7 #11493
Comments
That is expected, as I wrote on the website it's a rollout over the week so I can catch bad bugs before everyone gets them. Patience. |
Do we know if that crash is a segfault or what? I guess it must mean -[Unknown] |
@hrydgard Opps... I forgot sorry 😅 |
I suppose the segfault means that while Which basically means It would've crashed earlier if the -[Unknown] |
I'm not sure that first one was even real (filtering is being weird) but this one is:
And this:
|
Hm. We seem to be missing a null check for -[Unknown] |
Yeah, OOM can probably explain a lot of the stranger ones... |
Failure during creation?
Hit an assert:
|
Hm, that assert is concerning - For the refcount one, I can't repro by forcing a compile/link failure, but we probably want a null check in DepalShaderCacheGLES pure virtual - more signals that NativeInitGraphics crash - hmm. Maybe some related condition where -[Unknown] |
Okay, so I think the hash map thing is happening due to a The simplest thing might be to wait for -[Unknown] |
A crash during cache loading isn't really such a terrible case, no user data will be lost at least... Not gonna let this stop 1.7.1 |
Turns out I was wrong in that the fix will make 1.7.1 :) I don't see any other really surprising big crashers, so I'm going to release 1.7.1 tomorrow and start at a pretty high rollout, before we go to 100%. |
Sir @hrydgard v1.7.1 is the final version and officialy release tomorrow in PlayStore? p.s sorry for my bad english and asking too much and thank you for your hard work to make ppsspp a better emulator god bless and happy halloween |
Depends if we find more critical issues, but hopefully 1.7.1 will be the final official one in the 1.7 series. |
That is wacky, but it has no business being in this thread. Please create a new issue report. |
Seems ok now in the latest build 1.7.1-28 |
How are the Play crashes looking now? Should we close this? -[Unknown] |
Well, it's not perfect but I don't think it's worse than before... |
Actually, this one is still happening, and I don't understand how:
Mainly on small/weak phones though, could be out of memory when it tries to alloc the temp buffer? |
Quietly pushed 1.7.4 to a subset on Play, and this thing is STILL happening. I don't get it.
|
My best guess is: what if the frame sync is off, and it never runs I don't see how the destination can be wrong, or the stride, or the height. So that's my only idea left... -[Unknown] |
Yup, that's got to be it. Checked in a fix for that too.... |
Pretty weird one:
|
But if the frame sync is so off that this happens, we have another serious bug somewhere.. |
Perhaps it's just during shutdown? Not sure about the pipeline, maybe an allocation failure... -[Unknown] |
Ah yeah, could be. My checked-in workaround should be good enough if it is. |
I'm declaring this mostly done and closing. Until the 1.8 one... |
It's time for the crash report thread again, preparing for 1.7.1!
Starting off with a golden oldie, this one is not actually new but deserves to be looked at:
(one phone that it happens on is Samsung Galaxy Grand Prime Pro (j2y18lte), Android 7.1)
The text was updated successfully, but these errors were encountered: