-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yoake crash in Android\linux in newest git version #8603
Comments
@hrydgard |
Maybe the PMP code has never worked on 64-bit platforms? My memory of it is that it looked hacky. -[Unknown] |
It work on windows 64 bit |
Well, I will try if i can reproduce these error in the next days -[Mrc] |
@maximu |
Well after some test It's not platform android specific because crash under linux too
|
Hmm, Linux ffmpeg source |
Under linux i try 1.1.1 same crash under x86_64 architecture ever worked in x86_64 under UNIX OS? Edit : Well I confirm Works under x86 linux (32bits no crash very poor perfomance but ok) But not work with 64bits (under linux always black screen) Under android only running some seconds after crash. .
|
That log above (Swscaler zero vector) looks like something nasty happened earlier, and corrupted memory or something. -[Unknown] |
@unknownbrackets before this and earlier log no much help log similar to linux SEI type 1 size trucanted after crash I/NativeApp( 5172): 33:02:698 decode I[ME]: HW/MediaEngine.cpp:87 FF: SEI type 1 size 40 truncated at 36 From lolipop 5.1 better permission track debug. in the finish debug signal
|
It's crashing in a free() inside a syscall, seems like.... based on Maybe the ffmpeg version in use needs to be recompiled for 64-bit? But, it seems to work generally on 64-bit. -[Unknown] |
@unknownbrackets Why remove "v1.2.2 milestone" |
Personally, I think we will be satisfied to release 1.2.2 without the EGL crash. @hrydgard do you want to drop x86-64 support in 1.2.2? -[Unknown] |
Oops, I missed this discussion. Hmm... |
We can safely drop x86_64 Android support although at a slight performance penalty on the few devices that support it, as they'll just run x86_32 instead. That would work around this issue. However, it's a rare issue on a rare platform (not many android x86-64 devices out there yet) so I'm leaning towards leaving it for 1.3.... |
@sum2012 it only worked in 1.1 because we didn't support x86_64 back then |
I don't mean it.My device is "asus zenfone 2" which is 32-bit os. |
@sum2012 you have a test Enabled x86 only : APP_ABI := x86 in https://github.com/hrydgard/ppsspp/blob/master/android/jni/Application.mk If happen crash too with disable x86_64 the main problem is other |
Oh, hm. Well, this is all very confusing... I can't hold up 1.2.2 for this as the crash fix in it is way more important. |
@maximu Don't work |
If it doesn't work to switch to x86, are you certain that #8455 is when it broke? The ffmpeg change in those commits only affected x86_64. The only other change was NDK_TOOLCHAIN_VERSION := 4.9, but I don't think (?) that would make a big difference, since I think we were already using 4.9. -[Unknown] |
@unknownbrackets Yes,comment NDK_TOOLCHAIN_VERSION := 4.9 fixed the issue |
Hmm. So maybe we were at 4.8 before after all. I would not be against switching back to 4.8 for a v1.2.3. Non-clang is now deprecated anyway. I think for 1.3.0 we should switch... let me see how much trouble that is... -[Unknown] |
I now need to work now,I will test it after 12 hours |
crash in a memory allocator? I would suspect broken __thread, but that was clang, right... |
It doesn't log "zero vector in scaling" on Windows (when it works), does it? -[Unknown] |
@maximu Does it fix linux x86_64 by |
hmmm gcc 4.8 no exist in the latest NDK.. But anyway in the oldest r10 NDK only exist gcc 4.9 for x86_64 |
@hrydgard how about disable pmp code in non-windows ? |
How is this now that the "PMP" stuff is disabled on non-Windows? It sounds like it didn't work previously, right? Also, we've just updated to using clang and a new FFmpeg build, which may help. -[Unknown] |
That's odd, it all works for me in Eclipse. Try reloading the project or something? (I haven't updated the SDK to the latest though ... let me try) |
@sum2012 make sure you modify some .java file and it actually builds. These days I mostly use ant to build it since I got tired of always doing that... -[Unknown] |
Instead of modifying a Java file you can rightclick the project and refresh, same effect. But yeah, it's annoying :) |
@sum2012 I just submitted a pull request to switch to target Android SDK 24. You could see if that helps, if you for example removed your old SDK. |
Well Confirm tested in android x86 32bit now working PMP video some little crappy sound in some moment but not crash in 32bit version. edit : Also tested change to clang the android x86_64bit version no longer crash perfomance working very well @unknownbrackets this problem are fixed in Android in both version 32 and 64bit. Need remove Platform-specific (Android) Now . |
Okay I found fixed in linux too need change Compiler. cmake -DCMAKE_C_COMPILER="/bin/clang" -DCMAKE_CXX_COMPILER="/bin/clang++" CMakeLists.txt && make because by default compile the emu with GCC compiler . Hurra Video PMP working when switched to clang in non Windows-OS ignore the flood log but for now not longer crash :P Need update wiki https://github.com/hrydgard/ppsspp/wiki/Build-instructions Recommended clang compiler insteand GCC for prevent this bug in Non-windows. Edit : Ignore the scale problem i reset display layout editor config scaling working ok. |
I know now from http://stackoverflow.com/questions/24790834/cant-fix-unsupported-major-minor-version-52-0-even-after-fixing-compatibility |
Updated the build instructions to note Clang as preferred. -[Unknown] |
This means you haven't updated the ffmpeg submodule. It also looks like you may be missing the glslang submodule. As noted elsewhere, you need to run -[Unknown] |
Pretty sure NDK r12b was supposed to fix that, per "__thread should work for real this time" in its release notes. It looks like you're using r10e. We now require r12b and use clang. -[Unknown] |
edit:work in ppsspp-v1.1.1-636-g8b27bc5-android
edit2:crash in ppsspp-v1.1.1-880-gb68f2de-android
crash log v1.2.1-2-g5f05539 :
https://gist.github.com/anonymous/5c1dd157de1d8cda09a8
The text was updated successfully, but these errors were encountered: