-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Linux #4
Conversation
For the broken fonts, try running ./buildassets.sh in /SDL, should copy the right texture atlas I hope. If not, try building atlastool in native/tools and run ./buildatlas.sh in /android, then run ./buildassets.sh in SDL again. Looking at your diff now. |
@@ -36,7 +38,7 @@ class FixedSizeQueue | |||
// Make copy constructor private for now. | |||
FixedSizeQueue(FixedSizeQueue &other) { } | |||
|
|||
public: | |||
public: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation needed? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, fonts work now!
No idea for that line of the diff, I didn't even realize it was here.
Either I added it by inattention or my text editor added it by itself. But
it's probably not needed.
2012/11/3 Henrik Rydgård [email protected]
In Common/FixedSizeQueue.h:
@@ -36,7 +38,7 @@ class FixedSizeQueue
// Make copy constructor private for now.
FixedSizeQueue(FixedSizeQueue &other) { }-public:
- public:
This indentation needed? :)
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4/files#r2024079.
I merged the other linux-fixing pull request, that seems to fix many of the same issues. Can you rebase your changes on the current state? |
Oh right, I didn't even see this merge request (actually seeing that there had been a merge from the same branch I thought everything that had been modified was merged). It works with this version too, so my push request becomes quite useless — he just did some things in different ways but I can't tell which one is better. That's not really important anyway. |
Excellent :) |
Adjust windows size based on renderWidth/renderHeight
Fix https://github.com/libretro/ppsspp/issues/5#issuecomment-383238875 Add missing file Bump this, in case you are building without .git/ folder Libretro: remove override directive. (#4)
Now compiles and runs on my 64-bit Gentoo Linux.
Fonts are broken in menu, but otherwise Puzzle Bobble Pocket worked.