Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Linux #4

Closed
wants to merge 1 commit into from
Closed

Fixes for Linux #4

wants to merge 1 commit into from

Conversation

artart78
Copy link
Contributor

@artart78 artart78 commented Nov 3, 2012

Now compiles and runs on my 64-bit Gentoo Linux.
Fonts are broken in menu, but otherwise Puzzle Bobble Pocket worked.

@hrydgard
Copy link
Owner

hrydgard commented Nov 3, 2012

For the broken fonts, try running ./buildassets.sh in /SDL, should copy the right texture atlas I hope. If not, try building atlastool in native/tools and run ./buildatlas.sh in /android, then run ./buildassets.sh in SDL again.

Looking at your diff now.

@@ -36,7 +38,7 @@ class FixedSizeQueue
// Make copy constructor private for now.
FixedSizeQueue(FixedSizeQueue &other) { }

public:
public:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation needed? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, fonts work now!
No idea for that line of the diff, I didn't even realize it was here.
Either I added it by inattention or my text editor added it by itself. But
it's probably not needed.

2012/11/3 Henrik Rydgård [email protected]

In Common/FixedSizeQueue.h:

@@ -36,7 +38,7 @@ class FixedSizeQueue
// Make copy constructor private for now.
FixedSizeQueue(FixedSizeQueue &other) { }

-public:

  • public:

This indentation needed? :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/4/files#r2024079.

@hrydgard
Copy link
Owner

hrydgard commented Nov 3, 2012

I merged the other linux-fixing pull request, that seems to fix many of the same issues. Can you rebase your changes on the current state?

@artart78
Copy link
Contributor Author

artart78 commented Nov 3, 2012

Oh right, I didn't even see this merge request (actually seeing that there had been a merge from the same branch I thought everything that had been modified was merged). It works with this version too, so my push request becomes quite useless — he just did some things in different ways but I can't tell which one is better. That's not really important anyway.
I'm going to try to work on more useful stuff now. xD

@artart78 artart78 closed this Nov 3, 2012
@hrydgard
Copy link
Owner

hrydgard commented Nov 3, 2012

Excellent :)

@ghost ghost mentioned this pull request Nov 30, 2012
@livisor livisor mentioned this pull request Mar 9, 2013
@hrydgard hrydgard mentioned this pull request Jul 19, 2013
thedax pushed a commit to thedax/ppsspp that referenced this pull request Jul 29, 2013
Adjust windows size based on renderWidth/renderHeight
@lzhiyong lzhiyong mentioned this pull request Oct 9, 2018
hrydgard pushed a commit that referenced this pull request Nov 2, 2018
Fix https://github.com/libretro/ppsspp/issues/5#issuecomment-383238875

Add missing file

Bump this, in case you are building without .git/ folder

Libretro: remove override directive. (#4)
@lim2222 lim2222 mentioned this pull request Jan 2, 2024
5 tasks
@hsoftxl hsoftxl mentioned this pull request Mar 7, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants