Adding HONEST score #279
Merged
Adding HONEST score #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
@lvwerra I'm getting an import error for the Any ideas? |
measurements/honest/README.md
Outdated
| Example 1: Calculating HONEST without groups | ||
|
|
||
| ```python | ||
| >>> honest = evaluate.load('measurements/honest', lang = 'en') |
There was a problem hiding this comment.
This is a config_name, not a lang, right?
There was a problem hiding this comment.
so I'm waiting for the big config to be merged so we can have different config names, including lang.
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
Co-authored-by: helen <[email protected]>
lvwerra
reviewed
Sep 27, 2022
| word = strip_accent(word) | ||
| if word in self.words: | ||
| list_score["count"] += 1 | ||
| list_score[self.get_hurtlex_category(word)] += 1 |
There was a problem hiding this comment.
the key "count" never occurs in self.get_hurtlex_category(word)? Otherwise you would overwrite it here.
There was a problem hiding this comment.
no it doesn't, it's not part of the lexicon. (although I do admit it's a fragile way of implementing it -- I took it directly from the HONEST code).
removing `predicted_words`
Co-authored-by: Leandro von Werra <[email protected]>
Co-authored-by: Leandro von Werra <[email protected]>
removing pandas and nump
lvwerra
approved these changes
Sep 29, 2022
NimaBoscarino
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Adding HONEST score * adding source of code * running make * added two modes for the score, group and no group * ran make * polishing up * ran make * updating requirements * adding unidecode to tests * Update measurements/honest/README.md Co-authored-by: helen <[email protected]> * Update measurements/honest/README.md Co-authored-by: helen <[email protected]> * Update measurements/honest/README.md Co-authored-by: helen <[email protected]> * Update measurements/honest/README.md Co-authored-by: helen <[email protected]> * Update README.md * Update measurements/honest/README.md Co-authored-by: helen <[email protected]> * Update measurements/honest/honest.py Co-authored-by: helen <[email protected]> * Update README.md * Update honest.py * Update measurements/honest/honest.py Co-authored-by: helen <[email protected]> * keeping lang as a parameter for now * fixing loading * Update honest.py removing `predicted_words` * Update measurements/honest/honest.py Co-authored-by: Leandro von Werra <[email protected]> * Update measurements/honest/honest.py Co-authored-by: Leandro von Werra <[email protected]> * Update requirements.txt removing pandas and nump * raising value error is config incorrect * Update honest.py Co-authored-by: helen <[email protected]> Co-authored-by: Leandro von Werra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding HONEST score from https://github.com/MilaNLProc/honest