Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-config-humanmade peer dependencies #56

Closed
rmccue opened this issue May 1, 2018 · 4 comments · Fixed by #101
Closed

Update eslint-config-humanmade peer dependencies #56

rmccue opened this issue May 1, 2018 · 4 comments · Fixed by #101
Assignees

Comments

@rmccue
Copy link
Member

rmccue commented May 1, 2018

The peer dependencies of our ESLint config need to be updated for ESLint 4:

warning " > [email protected]" has incorrect peer dependency "eslint@^3.8.1".
warning " > [email protected]" has incorrect peer dependency "eslint@^2.10.2 || 3.x".                                                                                    
warning " > [email protected]" has incorrect peer dependency "eslint@^2.0.0 || ^3.0.0".  
@pdewouters
Copy link
Contributor

warning " > [email protected]" has incorrect peer dependency "babel-eslint@^7.0.0".
warning " > [email protected]" has unmet peer dependency "eslint-config-react-app@^0.5.0".
warning " > [email protected]" has incorrect peer dependency "eslint-plugin-jsx-a11y@^2.2.3".
warning " > [email protected]" has incorrect peer dependency "eslint-plugin-react@^6.4.1".

@kadamwhite
Copy link
Contributor

@rmccue I'm working on this, but it's a branch off of #42 because then we can actually test that the upgrades work without linking into another project, so if we can land #42 that'd be a big help!

@kucrut
Copy link

kucrut commented May 22, 2018

Upon upgrading to version 0.5.0, I got

warning " > [email protected]" has incorrect peer dependency "eslint-plugin-jsx-a11y@^5.1.1".

@kucrut kucrut reopened this May 22, 2018
@kadamwhite
Copy link
Contributor

eslint-config-react-app has used v6.0.2 of eslint-plugin-jsx-a11y since January, but there hasn't been a release since. 🤞 that we'll get one soon (which would automatically resolve that part of this issue, although it will also force us to upgrade to babel-eslint ^8.2!)

In the meantime, other than producing noise on installation the warning should be safe to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants