Update ESLint config peer dependencies #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`href-no-hash` has been replaced by a more comprehensive `anchor-is-valid` rule, but the React App ESLint config has not yet updated to support this recent version of the a11y ESLint rules. We want the more robust behavior, so we manually disable the removed rule (with a comment to revisit later) and manually specify the new rule in our config.
rmccue
approved these changes
May 13, 2018
|
Heya! Looking for an update on this as it flags as a blocker for a project. Next steps here? thnx! |
|
I think it’s ready to go, we need a patch release to get this on NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
The update process to the latest available versions of all packages was generally straightforward, excepting one new jsx-a11y rule that the react app configuration does not yet support. I worked around this by swapping the deprecated rule out for the new one in our own config.
This could use some more testing in real projects, so anybody who can
npm linkthis in and give it a run, please report your findings!