#142 - Add new Isset sniff #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, they're treated the same by most of our tooling, so it doesn't really matter. Generally though I'd say stylistic stuff would be a warning, if we do ever want to fix that in the future.
No, as it's not required to build a secure/performant site. |
|
@rmccue @kadamwhite I just changed this to add a waning now, not an error. Is this good to go in? 🙂 |
fklein-lu
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sniff,
HM.PHP.Issetthat throws an error forissetcalls with more than one argument, as per request in #142.I wasn't sure if wanted to make this an error, or just a warning. Looking at existing warnings and errors, I think we are rather inconsistent. Some Layout and opinionated sniffs throw errors, while others just warn about stuff that makes perfect sense to follow.
Thoughts?
Do we want to make this a part of
HM-Minimum?