Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bridges pot currency swap accounts inititialization #716

Merged
merged 40 commits into from
Aug 15, 2023
Merged

Implement bridges pot currency swap accounts inititialization #716

merged 40 commits into from
Aug 15, 2023

Conversation

dmitrylavrenov
Copy link
Contributor

No description provided.

@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch 8 times, most recently from dcad6ac to fc81ea2 Compare August 7, 2023 18:12
@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from fc81ea2 to bca632c Compare August 7, 2023 18:13
@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from 07a30b2 to a71541e Compare August 8, 2023 12:05
@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from df49627 to 6a09b50 Compare August 8, 2023 13:58
@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review August 8, 2023 17:08
@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII August 8, 2023 17:09
@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from 44a6f22 to 35c4ef1 Compare August 11, 2023 08:01
@dmitrylavrenov @MOZGIII
Fix typos
5ef7ed1 
Co-authored-by: MOZGIII <[email protected]>
@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from 35c4ef1 to 5ef7ed1 Compare August 11, 2023 08:02
MOZGIII
MOZGIII approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Last minute finding: now the only thing lacking is proper test descriptions - for what each test aims to verify. Let's add that and we can merge!

@dmitrylavrenov
Copy link
Contributor Author

Great! Last minute finding: now the only thing lacking is proper test descriptions - for what each test aims to verify. Let's add that and we can merge!

Sure, check please - ea09ee7.

@dmitrylavrenov dmitrylavrenov force-pushed the pallet-bridges-init-currency-swap branch from ea09ee7 to 53dde76 Compare August 15, 2023 10:04
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Aug 15, 2023
Merged via the queue into master with commit 2721b2b Aug 15, 2023
@dmitrylavrenov dmitrylavrenov deleted the pallet-bridges-init-currency-swap branch August 15, 2023 11:08
@dmitrylavrenov dmitrylavrenov mentioned this pull request Aug 16, 2023
Merged
@dmitrylavrenov dmitrylavrenov mentioned this pull request Aug 23, 2023
Closed
@dmitrylavrenov dmitrylavrenov mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrylavrenov @MOZGIII