Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix training baseline models #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix training baseline models #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5557ac9
Fix left-over debug pdb command
m0re4u Aug 30, 2022
9890c46
Fixed saving only best model and train for only 20 epochs max
m0re4u Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CollaborativeBuilding/builder/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"seed": 0,
"train_config": {
"batch_size": 50,
"num_epochs": 50,
"num_epochs": 20,
"warm_up_steps": 1,
"warm_up_factor": 0.1,
"beta1": 0.9,
Expand Down
2 changes: 0 additions & 2 deletions CollaborativeBuilding/builder/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import torch.nn.functional as F
from torch.nn.utils.rnn import pack_padded_sequence, pad_packed_sequence
from builder.dataloader_with_glove import BuilderDataset, RawInputs
import pdb
sys.path.append('..')
from utils import *

Expand All @@ -27,7 +26,6 @@ def __init__(self, config, vocabulary):

def forward(self, encoder_inputs, grid_repr_inputs, action_repr_inputs, label, location_mask=None, raw_input=None, dataset=None):
dialogue_repr = self.encoder(encoder_inputs)
pdb.set_trace()
loss, acc, predicted_seq = self.decoder(dialogue_repr, grid_repr_inputs, action_repr_inputs, label, location_mask, raw_input, dataset)
return loss, acc, predicted_seq

Expand Down
6 changes: 3 additions & 3 deletions CollaborativeBuilding/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def main(args, config):
json.dump(config, f)

optimizer = optim.Adam(model.parameters(), lr=train_config["lr"], betas=(train_config["beta1"], train_config["beta2"]))
max_f1 = 0

for epoch in range(train_config['num_epochs']):
print("Training...")
Expand Down Expand Up @@ -150,16 +151,15 @@ def main(args, config):
total_actions += len(labels)

train_loss = train_loss / len(train_items)

print('Train | Loss: {}'.format(train_loss))
print('Train | Location Acc: {}, Action Type Acc: {}, Color Acc: {}'.format(total_location_correct/total_location, total_action_type_correct/total_actions, total_color_correct/total_color))
f_output.write('Epoch {}\n'.format(epoch))
f_output.write('Epoch {}\n'.format(epoch))
f_output.write('Train | Loss: {}\n'.format(train_loss))
f_output.write('Train | Location Acc: {}, Action Type Acc: {}, Color Acc: {}\n'.format(total_location_correct/total_actions, total_action_type_correct/total_actions, total_color_correct/total_color))

model.eval()
valid_loss = 0
max_f1 = 0
valid_pred_seqs = []
valid_raw_inputs = []

Expand Down
3 changes: 3 additions & 0 deletions CollaborativeBuilding/train_collab.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash

python3 train.py --json_data_dir builder_data_with_glove --saved_models_path saved_models_$1 --seed $1