Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring a default groupId when it is null when using hyperf/kafka. #4738

Merged
merged 4 commits into from
May 16, 2022
Merged

Configuring a default groupId when it is null when using hyperf/kafka. #4738

merged 4 commits into from
May 16, 2022

Conversation

huangdijia
Copy link
Member

yiming0
yiming0 reviewed May 12, 2022
View reviewed changes
Copy link

@yiming0 yiming0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 AbstractConsumer::getGroupId() 方法返回默认值会不会好一点？

@huangdijia
Copy link
Member Author

在 AbstractConsumer::getGroupId() 方法返回默认值会不会好一点？

AbstractConsumer::getGroupId() 返回类型是 null|string 哦

@huangdijia
Copy link
Member Author

@limingxinleo 帮忙看看？

limingxinleo
limingxinleo previously approved these changes May 16, 2022
View reviewed changes
@limingxinleo limingxinleo changed the title Give a default groupId when it is null Configuring a default groupId when it is null when using hyperf/kafka. May 16, 2022
@limingxinleo limingxinleo merged commit 5af8cc0 into hyperf:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiming0 yiming0 yiming0 left review comments

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangdijia @limingxinleo @yiming0