feat: add transfer and call #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yorhodes
reviewed
Feb 21, 2025
|
|
||
| Some scenarios include: | ||
|
|
||
| - A user deposits assets on an L2, mints a derivative, and then needs to bridge the underlying asset to an L1 vault for further use. |
There was a problem hiding this comment.
Suggested change
| - A user deposits assets on an L2, mints a derivative, and then needs to bridge the underlying asset to an L1 vault for further use. | |
| - A user deposits assets on an L2, mints a derivative, and then needs to bridge the underlying asset to an L1 vault for collateralization. |
|
|
||
| 1. Tokens are transferred from the sender to the contract. | ||
| 2. An [Interchain Account (ICA)](/docs/reference/applications/interchain-account) is derived for the contract on the destination chain. | ||
| 3. The Warp Route transfer is initiated, sending the tokens cross-chain. |
There was a problem hiding this comment.
Suggested change
| 3. The Warp Route transfer is initiated, sending the tokens cross-chain. | |
| 3. The Warp Route transfer is initiated, sending the tokens crosschain to the interchain account |
| 1. Tokens are transferred from the sender to the contract. | ||
| 2. An [Interchain Account (ICA)](/docs/reference/applications/interchain-account) is derived for the contract on the destination chain. | ||
| 3. The Warp Route transfer is initiated, sending the tokens cross-chain. | ||
| 4. A remote contract call is executed after the tokens arrive. |
There was a problem hiding this comment.
Suggested change
| 4. A remote contract call is executed after the tokens arrive. | |
| 4. A remote contract call is executed on the destination chain from the interchain account after the tokens arrive. |
|
|
||
| :::note | ||
|
|
||
| - The contract must ensure the tokens arrive before executing the follow-up action. |
There was a problem hiding this comment.
maybe add a note about most calls requiring a token balance will revert before the tokens arrive and that the relayer retries with backoff to deliver the ICA call
There was a problem hiding this comment.
also that the ICA may need to do an ERC20 approval call in addition to a deposit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the transfer and call pattern to the docs.
Open Questions: