-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): upgrade web3 project-wide to v1.6.1 #2332
Labels
Comments
@petermetz Hello Peter I'll be taking this ticket. Thank you. |
micoferdinand98
added a commit
to micoferdinand98/cactus
that referenced
this issue
Jul 12, 2023
petermetz
added a commit
to micoferdinand98/cactus
that referenced
this issue
Jul 15, 2023
Fixes hyperledger-cacti#2332 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to micoferdinand98/cactus
that referenced
this issue
Jul 16, 2023
Update from Peter: I needed to do an unsafe cast because that was the least bad option (other option was to make a breaking change in the quourm connector's API). The issue opened for tracking a proper resolution to this is titled as: refactor(connector-quorum): make Web3BlockHeader.receiptRoot optional hyperledger-cacti#2555 and the link to it on GitHub is hyperledger-cacti#2555 Fixes hyperledger-cacti#2332 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this issue
Jul 17, 2023
Update from Peter: I needed to do an unsafe cast because that was the least bad option (other option was to make a breaking change in the quourm connector's API). The issue opened for tracking a proper resolution to this is titled as: refactor(connector-quorum): make Web3BlockHeader.receiptRoot optional #2555 and the link to it on GitHub is #2555 Fixes #2332 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this issue
Dec 21, 2023
Update from Peter: I needed to do an unsafe cast because that was the least bad option (other option was to make a breaking change in the quourm connector's API). The issue opened for tracking a proper resolution to this is titled as: refactor(connector-quorum): make Web3BlockHeader.receiptRoot optional hyperledger-cacti#2555 and the link to it on GitHub is hyperledger-cacti#2555 Fixes hyperledger-cacti#2332 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
There is already a pull request 1 (#2271) out there - sent by the robots - to force the upgrading of the
cookiejar
dependency via the lock file, but we would like to make sure that the parent dependencies ofcookiejar
are also upgraded and the way to get that done is to upgrade web3 within the project.This will make sure that the lockfile getting reset does not re-introduce the vulnerability that is being fixed by #2271.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: