fix(vscode/devcontainer): unexpected exit stdout /etc/passwd #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
sandeepnRES
approved these changes
May 8, 2023
sandeepnRES
force-pushed
the
petermetz/issue2404
branch
from
14dbb3b to
0e871fc
Compare
jagpreetsinghsasan
approved these changes
May 8, 2023
sandeepnRES
force-pushed
the
petermetz/issue2404
branch
from
0e871fc to
154f9b1
Compare
petermetz
force-pushed
the
petermetz/issue2404
branch
from
154f9b1 to
a85578c
Compare
sandeepnRES
force-pushed
the
petermetz/issue2404
branch
from
a85578c to
bc4d95b
Compare
petermetz
force-pushed
the
petermetz/issue2404
branch
from
bc4d95b to
a9cded1
Compare
petermetz
force-pushed
the
petermetz/issue2404
branch
2 times, most recently
from
0a6e7e2 to
fa1af87
Compare
1. Moved away from trying to handroll an Ubuntu-22.04 image for the dev container and instead used the "features" feature (no pun intended) of the dev container spec: https://code.visualstudio.com/blogs/2022/09/15/dev-container-features 2. This produces a container that builds and launches reliably without the issues the previous version was suffering from (which was that to some people the container would just exit randomly during the launch) 3. Our future goal of having the dev container being built in a reproducible way is still not achieved, but we've gotten closer because in the meantime while working on this issue it was discovered that we can re-build the images directly from the CLI by using the dev container CLI package: https://github.com/devcontainers/cli 4. The upside of not building the image from scratch is that we can count on future improvements/maintenance from others who are working on these images. 5. The downside of not building the image from scratch is that if we end up finding something that does not work due to the customizations, it might be more difficult to figure that out compared to if we had just build our own. 6. It is hard to predcit right now whether 4) or 5) will end up being having the stronger effect, but we can cross that bridge when we get to it. 7. In the meantime I've started working on a contribution to the dev container CLI itself for a dockerfile ejection feature (meaning that we'll be able to render a single Dockerfile for the dev container (that right now the CLI only stores/uses internally in it's own code at runtime). This eject feature will be good for debugging purposes in case anything goes wrong with the image in the future. 8. Also added a publishing workflow action that will build the dev container image on the main branch when there is a release tag (v*) issued. Fixes hyperledger-cacti#2404 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
petermetz/issue2404
branch
from
fa1af87 to
ca7bdf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and instead used the "features" feature (no pun intended) of the dev container
spec: https://code.visualstudio.com/blogs/2022/09/15/dev-container-features
issues the previous version was suffering from (which was that to some people
the container would just exit randomly during the launch)
way is still not achieved, but we've gotten closer because in the meantime
while working on this issue it was discovered that we can re-build the images
directly from the CLI by using the dev container CLI package:
https://github.com/devcontainers/cli
future improvements/maintenance from others who are working on these images.
finding something that does not work due to the customizations, it might be
more difficult to figure that out compared to if we had just build our own.
the stronger effect, but we can cross that bridge when we get to it.
CLI itself for a dockerfile ejection feature (meaning that we'll be able to
render a single Dockerfile for the dev container (that right now the CLI only
stores/uses internally in it's own code at runtime). This eject feature will
be good for debugging purposes in case anything goes wrong with the image in the
future.
Fixes #2404
Signed-off-by: Peter Somogyvari [email protected]