feat(weaver/common): add data view protocol buffer spec & RFCs for Besu #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VattiPraveen
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
requested changes
Jul 22, 2023
There was a problem hiding this comment.
@VattiPraveen Thank you! Please do the following:
- Squash into a single commit
- Make sure the message uniquely describes what is being done - the current commit messages of "modified X" are not unique because literally every commit ever does exactly
thatso it's hard to read the commit log that way if too many of these slip into the log. - Once you've come up with a good commit message please sync that up to the PR title and the PR description as well.
- Please read the contributing.md guide for further details
Other than my usual administrative nit-picks: LGTM
petermetz
changed the title
petermetz
requested changes
Jul 22, 2023
There was a problem hiding this comment.
@VattiPraveen I modified the PR title with a commit subject suggestion. If you agree then you can just make that your commit subject when you squash.
Hi @petermetz. I have made the changes as you suggested. Please review the PR. |
sandeepnRES
approved these changes
Jul 25, 2023
petermetz
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@VattiPraveen Nice! Now you just need to fix the DCO from what I can tell and then we should be good to go.
Signed-off-by: VattiPraveen <[email protected]>
petermetz
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(weaver/common): add data view protocol buffer spec & RFCs for Besu