Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linter warning in CreateCorsMiddleware #2697

Conversation

bmvd70
Copy link
Contributor

@bmvd70 bmvd70 commented Sep 17, 2023

Imported CorsOptionsDelegate and CorsRequest and typed corsOptionsDelegate to it

Closes: #2674

Possibly not a chore, but a style issue

[skip ci]

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmvd70 Thank you, LGTM!

Imported CorsOptionsDelegate and CorsRequest and typed
corsOptionsDelegate to it

[skip ci]

Closes: hyperledger-cacti#2674

Signed-off-by: bmvd70 <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the fix-linter-warning-in-createCorsMiddleware branch from e240131 to 1e18964 Compare September 18, 2023 18:28
@petermetz petermetz merged commit 1e18964 into hyperledger-cacti:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(cmd-api-server): fix linter warning in CreateCorsMiddleware
3 participants