Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(devcontainer): switch to JDK 8 (for Corda v4) and Node 20 LTS #2891

Merged

Conversation

petermetz
Copy link
Contributor

  1. Also performed a minor upgrade of the golang compiler version
    because the version we were using had a bug in it (compiler bug)

[skip ci]

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@outSH
Copy link
Contributor

outSH commented Nov 16, 2023

@petermetz Why move to Node 20 LTS while 18 LTS is still supported? I think it's better to use 18 to ensure compatibility of any new changes with it, or is there a specific reason to use 20?

takeutak
takeutak previously approved these changes Nov 24, 2023
@takeutak takeutak dismissed their stale review November 24, 2023 17:44

Sorry, I missed @outSH 's comment. I will approve after this comment issue is resolved.

@petermetz
Copy link
Contributor Author

@petermetz Why move to Node 20 LTS while 18 LTS is still supported? I think it's better to use 18 to ensure compatibility of any new changes with it, or is there a specific reason to use 20?

@outSH No strong feelings in either direction TBH (I could argue for both 18 and 20) so I'll switch it to 18!

@petermetz petermetz force-pushed the build-devcontainer-jdk8-node20 branch from ac10982 to 19e00ee Compare December 2, 2023 21:06
@petermetz petermetz requested a review from takeutak December 2, 2023 21:06
@petermetz
Copy link
Contributor Author

Sorry, I missed @outSH 's comment. I will approve after this comment issue is resolved.

@takeutak No worries and thank you for the review! I just made the changes to accommodate the feedback from @outSH !

… LTS

1. Also performed a minor upgrade of the golang compiler version
because the version we were using had a bug in it (compiler bug)

[skip ci]

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the build-devcontainer-jdk8-node20 branch from 19e00ee to 8388300 Compare December 5, 2023 00:32
@petermetz petermetz merged commit 73fc74d into hyperledger-cacti:main Dec 5, 2023
@petermetz petermetz deleted the build-devcontainer-jdk8-node20 branch December 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants