fix(cactus-common): coerceUnknownToError() now uses HTML sanitize #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
outSH
requested changes
Dec 6, 2023
packages/cactus-common/src/main/typescript/exception/coerce-unknown-to-error.ts
Show resolved
Hide resolved
petermetz
force-pushed
the
fix-common-coerce-unknown-to-error-sanitize
branch
from
7cf4a73 to
bba0f24
Compare
outSH
approved these changes
Dec 28, 2023
petermetz
force-pushed
the
fix-common-coerce-unknown-to-error-sanitize
branch
from
bba0f24 to
a760d00
Compare
1. This is a security fix so that the exception serialization does not accidentally XSS anybody who is looking at crash logs through some admin GUI that is designed to show logs that are considered trusted. Related discussion about `1)` can be seen at this other pull request: hyperledger-cacti#2893 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
fix-common-coerce-unknown-to-error-sanitize
branch
from
a760d00 to
24459e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accidentally XSS anybody who is looking at crash logs through some
admin GUI that is designed to show logs that are considered trusted.
Related discussion about
1)can be seen at this other pull request:#2893
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.