chore(cactus-plugin-ledger-connector-cdl-socketio): remove old connector #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
103
to
116
| const requestResponse = await axios({ | ||
| httpsAgent, | ||
| method: httpMethod, | ||
| baseURL, | ||
| url, | ||
| responseType: "json", | ||
| headers: { | ||
| "User-Agent": userAgent, | ||
| "Content-Type": "application/json;charset=UTF-8", | ||
| ...authHeaders, | ||
| }, | ||
| params: queryParams, | ||
| data: dataPayload, | ||
| }); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
| this.log.info( | ||
| `Allowing self signed CDL API GW certificates (skipCertCheck=${skipCertCheck})`, | ||
| ); | ||
| agentOptions.rejectUnauthorized = false; |
Check failure
Code scanning / CodeQL
Disabling certificate validation High
sandeepnRES
force-pushed
the
remove_cdl_socketio_pr
branch
from
1f1c62c to
09cc017
Compare
|
This PR/issue depends on:
|
- Remove old connector cactus-plugin-ledger-connector-cdl-socketio. It's been
replaced with socketio-based cactus-plugin-ledger-connector-cdl.
Depends on hyperledger-cacti#2962
Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
remove_cdl_socketio_pr
branch
from
09cc017 to
19cd7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced with socketio-based cactus-plugin-ledger-connector-cdl.
Depends on #2962
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.