feat(bungee-hermes): process & merge views #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/cactus-plugin-bungee-hermes/src/main/typescript/plugin-bungee-hermes.ts
Fixed
Show fixed
Hide fixed
packages/cactus-plugin-bungee-hermes/src/main/typescript/plugin-bungee-hermes.ts
Fixed
Show fixed
Hide fixed
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
from
8f63e72 to
930c855
Compare
eduv09
requested review from
RafaelAPB,
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
from
930c855 to
03d2e6e
Compare
packages/cactus-plugin-bungee-hermes/src/main/typescript/plugin-bungee-hermes.ts
Fixed
Show resolved
Hide resolved
petermetz
requested changes
May 9, 2024
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-creation/view.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-creation/view.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-merging/integrated-view.ts
Outdated
Show resolved
Hide resolved
RafaelAPB
requested changes
May 9, 2024
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-creation/privacy-policies.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-creation/view.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/main/typescript/view-creation/view.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/main/typescript/plugin-bungee-hermes.ts
Fixed
Show resolved
Hide resolved
packages/cactus-plugin-bungee-hermes/src/test/typescript/integration/bungee-merge-views.test.ts
Show resolved
Hide resolved
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
from
03d2e6e to
7c18f38
Compare
packages/cactus-plugin-bungee-hermes/src/main/typescript/plugin-bungee-hermes.ts
Fixed
Show fixed
Hide fixed
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
from
7c18f38 to
1c8fabf
Compare
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
2 times, most recently
from
9571782 to
bfb2a5e
Compare
petermetz
approved these changes
May 10, 2024
There was a problem hiding this comment.
@eduv09 LGTM - if you feel like the reasoning makes sense then please also apply this change if you have enough time: #3250 (comment)
RafaelAPB
approved these changes
May 11, 2024
eduv09
force-pushed
the
bungee-hermes-proccess-views
branch
from
bfb2a5e to
8f35150
Compare
|
@petermetz I applied the changes. Both start as negative values now. Thank you! I think we can merge it now. |
- Added new types for view merging - Created some merge and process policies for demonstration - new endpoints and plugin logic to merge and process views - two new tests to test new functionality - utility function to fully deserialize a view - slightly changed View type, to keep reccord of its old versions metadata - updated README.md Signed-off-by: eduv09 <[email protected]>
petermetz
force-pushed
the
bungee-hermes-proccess-views
branch
from
8f35150 to
e02c1d8
Compare
@eduv09 Got it, thank you! I'll try to merge it today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUNGEE-Hermes is supposed to be able to process and merge views, following 'privacy-policies' (which are basicaly functions that alter the data included in a View/IntegratedView).
The algorithm of Merging views is detailed in the paper BUNGEE.
Summary of Changes: