-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): DeprecationWarning in yarn_custom_checks #3309
fix(ci): DeprecationWarning in yarn_custom_checks #3309
Conversation
797b027
to
53d0b3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please try to create yarn patches for the affected dependencies? https://yarnpkg.com/cli/patch
For example I manually edited this file:
examples/cactus-example-carbon-accounting-frontend/node_modules/@ionic-native/status-bar/package.json
By replacing this
"main":"bundle.js",
with this:
"main":"./ngx/bundle.js",
And the warning went away, so I'm thinking if you created yarn patches for all the ones with the warnings then we could get it done all the way through.
@petermetz I have tried using the yarn patches and it worked but when I try to run yarn run configure I get this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez Alright, I investigated this a little further and it's going to need a bigger change in a different PR so for now let's just merge this as-is and I'll send another with the rest of the warnings. LGTM, thank you!
53d0b3d
to
41aa579
Compare
Primary Changes ---------------- 1. Updated the main field to use index.js to fix the Deprecation Warning Peter's Fixes: ---------------- 1. I fixed the file paths in the require statements to match the new location after we've remapped the bundle location in the package.json files. Fixes hyperledger-cacti#2956 Co-Authored-by: Peter Somogyvari <[email protected]> Signed-off-by: aldousalvarez <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
41aa579
to
96a3865
Compare
Commit to be reviewed
fix(ci): DeprecationWarning in yarn_custom_checks
Fixes #2956
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.