Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish v2.0.0-rc.7 #3567

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore(release): publish v2.0.0-rc.7 #3567

merged 1 commit into from
Oct 2, 2024

Conversation

petermetz
Copy link
Contributor

Hot-fixing the automatic release issuance workflow for npm packages yet again.
The previous fix is still believed to bo correct conceptually, there was just
a silly mistake of the mixing up of the ghcr vs npm tokens in the environment
variables that get populated from the secrets.

Fixes #451

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the release-v2.0.0-rc.7 branch from 8e85a26 to 485de1c Compare October 2, 2024 17:02
Hot-fixing the automatic release issuance workflow for npm packages yet again.
The previous fix is still believed to bo correct conceptually, there was just
a silly mistake of the mixing up of the ghcr vs npm tokens in the environment
variables that get populated from the secrets.

Fixes #451

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the release-v2.0.0-rc.7 branch from 485de1c to 367d9ee Compare October 2, 2024 17:44
@petermetz petermetz merged commit 367d9ee into main Oct 2, 2024
145 of 148 checks passed
@petermetz petermetz deleted the release-v2.0.0-rc.7 branch October 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(release-automation): make release issuance atomic
3 participants