Withdrawals wiring #4968
Merged
Withdrawals wiring #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siladu
approved these changes
Jan 20, 2023
| import org.mockito.junit.jupiter.MockitoExtension; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class MainnetBlockBodyValidatorTest { |
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Add withdrawalsRoot as part of BodyIdentifier Add comment to avoid new issues when adding new fields to BlockBody Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
…bled at genesis Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Add empty withdrawals in GenesisState for shanghai at genesis Signed-off-by: Simon Dudley <[email protected]>
siladu
force-pushed
the
withdrawalsRoot_encoding
branch
from
7473a3a to
ada45e1
Compare
jframe
added
TeamGroot
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* add withdrawalRoot computation Signed-off-by: Jason Frame <[email protected]> * include withdrawalsRoot and withdrawals when creating block Signed-off-by: Jason Frame <[email protected]> * validate withdrawals when validation mainnet blocks Signed-off-by: Jason Frame <[email protected]> * Fix invalid withdrawals root during backwards sync Add withdrawalsRoot as part of BodyIdentifier Add comment to avoid new issues when adding new fields to BlockBody Signed-off-by: Jason Frame <[email protected]> * Include withdrawalsRoot when creating new header in EngineNewPayload Signed-off-by: Jason Frame <[email protected]> * Use empty trie hash in genesis for withdrawalsRoot if shanghai is enabled at genesis Signed-off-by: Jason Frame <[email protected]> * Revert testing changes to AbstractEngineNewPayload Signed-off-by: Jason Frame <[email protected]> * Fix BesuController tests failing after GenesisState change Signed-off-by: Jason Frame <[email protected]> * Missing withdrawals wiring in BlockProcessor Add empty withdrawals in GenesisState for shanghai at genesis Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Jason Frame <[email protected]> Co-authored-by: Simon Dudley <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* add withdrawalRoot computation Signed-off-by: Jason Frame <[email protected]> * include withdrawalsRoot and withdrawals when creating block Signed-off-by: Jason Frame <[email protected]> * validate withdrawals when validation mainnet blocks Signed-off-by: Jason Frame <[email protected]> * Fix invalid withdrawals root during backwards sync Add withdrawalsRoot as part of BodyIdentifier Add comment to avoid new issues when adding new fields to BlockBody Signed-off-by: Jason Frame <[email protected]> * Include withdrawalsRoot when creating new header in EngineNewPayload Signed-off-by: Jason Frame <[email protected]> * Use empty trie hash in genesis for withdrawalsRoot if shanghai is enabled at genesis Signed-off-by: Jason Frame <[email protected]> * Revert testing changes to AbstractEngineNewPayload Signed-off-by: Jason Frame <[email protected]> * Fix BesuController tests failing after GenesisState change Signed-off-by: Jason Frame <[email protected]> * Missing withdrawals wiring in BlockProcessor Add empty withdrawals in GenesisState for shanghai at genesis Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Jason Frame <[email protected]> Co-authored-by: Simon Dudley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Final piece to wire together withdrawals and adding missing pieces
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog