Use PascalCase for preact component modules and related assets #2933
Conversation
lyzadanger
force-pushed
the
Pascal-case-ify-components
branch
from
bfc579d to
c2eee0a
Compare
|
Putting this in draft as I work through fixing CI issues: pitfalls of working on OS that isn't truly case-sensitive. |
Codecov Report
@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
- Coverage 97.80% 97.80% -0.01%
==========================================
Files 206 206
Lines 7757 7755 -2
Branches 1723 1722 -1
==========================================
- Hits 7587 7585 -2
Misses 170 170
Continue to review full report at Codecov.
|
|
That testcov fail ain't my doing. |
There was a problem hiding this comment.
I just found one questionable class name that I think should change then this looks GTG. Also we will need to switch out components in frontend-shared/src perhaps with or after the annotator changes. Currently there is no /components folder in frontend-shared but that maybe should change.
| @@ -25,17 +25,17 @@ import VersionInfo from './version-info'; | |||
| */ | |||
| function HelpPanelTab({ linkText, url }) { | |||
| return ( | |||
| <div className="help-panel-tabs__tab"> | |||
| <div className="HelpPanel-tabs__tab"> | |||
There was a problem hiding this comment.
This one looks off.
Should be this HelpPanelTab__tab or perhaps just HelpPanelTab
| @@ -4,13 +4,13 @@ import { createElement } from 'preact'; | |||
| * Loading indicator. | |||
| */ | |||
| export default function Spinner() { | |||
| // The `spinner__container` div only exists to center the spinner within | |||
| // the `<spinner>` Angular component element. Once consumers of this component | |||
robertknight
force-pushed
the
Pascal-case-ify-components
branch
from
c2eee0a to
a8d51a7
Compare
|
I have rebased this on master after the change to move |
| @@ -53,14 +53,14 @@ export default function AutocompleteList({ | |||
| // The parent <input> field should capture keyboard events | |||
| // eslint-disable-next-line jsx-a11y/click-events-have-key-events | |||
| <li | |||
| key={`autocomplete-list-${index}`} | |||
| key={`AutocompleteList-${index}`} | |||
There was a problem hiding this comment.
The key could just be index here, since it only needs to be unique amongst its siblings.
This PR makes the following changes:
AnnotationBody-test.js)Annotator components haven't been touched (yet).