Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC samples averaging with added STM32F30x support #3268

Merged
merged 3 commits into from
May 31, 2018

Conversation

shellixyz
Copy link
Collaborator

Duplicate changes made to the F4 ADC driver in #3190 in the F3 ADC driver

Supersedes #3190

Copy link
Member

@digitalentity digitalentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't enable averaging for any target. Are we going to have a separate PR to do it?

@shellixyz
Copy link
Collaborator Author

@digitalentity I can add it to this PR. 20 samples seems to work well. Should we start with this value for both F3 and F4 ?

@shellixyz shellixyz force-pushed the adc_averaging_stm32f3 branch from cc5d800 to 755b7ba Compare May 30, 2018 23:40
@shellixyz shellixyz force-pushed the adc_averaging_stm32f3 branch from 755b7ba to 15955b5 Compare May 30, 2018 23:43
@shellixyz
Copy link
Collaborator Author

I added 20 samples averaging for F3 and F4 targets. Should be good to merge.

@digitalentity digitalentity merged commit 1b0d888 into iNavFlight:development May 31, 2018
@digitalentity
Copy link
Member

@mluessi @shellixyz thanks!

@mluessi
Copy link
Contributor

mluessi commented May 31, 2018

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants