-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringBuilder in IcalParser.cs #123
Conversation
I like to keep my PRs telling a single story, with each commit as a coherent chapter in that story. PRs with a single small commit are totally fine. This PR has two stories in it:
|
Your PR prompted me to (finally) write a guide for pull requests, and while I was doing that, I wrote a guide for bug reports. |
Fixed the PR after your suggestions. |
Looks good. Can you squash them all down into a single commit with a message like "Use StringBuilders in IcalParser #124" Then I'll merge it. After the other bug fix is in, I'll build and publish a new nuget package, and update both issues with the relevant commit SHA and nuget version. |
Did you mean to close this? |
No, I think Github did it whene I removed the commits to replace them with a singel commit. |
Finaly, ther it is... Hop it's ok and this one is closeable now. |
I made you a collaborator. Go ahead and merge it. In general, please wait a day or three so I can look at your code when you open a PR. I'll usually make some comments, or just say "looks good". If I need more time to review it, I'll let you know that, too. |
Fix #12