Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringBuilder in IcalParser.cs #123

Merged
merged 1 commit into from
Sep 4, 2016
Merged

Conversation

dahermansson
Copy link
Collaborator

Fix #12

@rianjs
Copy link
Collaborator

rianjs commented Sep 3, 2016

I like to keep my PRs telling a single story, with each commit as a coherent chapter in that story. PRs with a single small commit are totally fine.

This PR has two stories in it:

  • StringBuilder: looks OK, except I'd rather you use var to declare it. It reduces file churn when types change.
  • Parsing issue: I'd point you to the issue you opened for the parse-related commit, also you didn't reference the issue you opened in the commit message (or PR message)

@rianjs
Copy link
Collaborator

rianjs commented Sep 3, 2016

Your PR prompted me to (finally) write a guide for pull requests, and while I was doing that, I wrote a guide for bug reports.

@dahermansson
Copy link
Collaborator Author

Fixed the PR after your suggestions.
I do another one to fix the bug I found. My intention from the beginning was not to include it in this PR, it just accidentally did anyway.

@rianjs
Copy link
Collaborator

rianjs commented Sep 3, 2016

Looks good. Can you squash them all down into a single commit with a message like "Use StringBuilders in IcalParser #124"

Then I'll merge it. After the other bug fix is in, I'll build and publish a new nuget package, and update both issues with the relevant commit SHA and nuget version.

@rianjs
Copy link
Collaborator

rianjs commented Sep 3, 2016

Did you mean to close this?

@dahermansson
Copy link
Collaborator Author

No, I think Github did it whene I removed the commits to replace them with a singel commit.

@dahermansson dahermansson reopened this Sep 3, 2016
@dahermansson
Copy link
Collaborator Author

Finaly, ther it is... Hop it's ok and this one is closeable now.

@rianjs
Copy link
Collaborator

rianjs commented Sep 3, 2016

I made you a collaborator. Go ahead and merge it.

In general, please wait a day or three so I can look at your code when you open a PR. I'll usually make some comments, or just say "looks good". If I need more time to review it, I'll let you know that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants