Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #14

Merged
merged 47 commits into from
May 30, 2016
Merged

Cleanup #14

merged 47 commits into from
May 30, 2016

Conversation

rianjs
Copy link
Collaborator

@rianjs rianjs commented May 30, 2016

No description provided.

rianjs added 30 commits May 28, 2016 19:01
@rianjs
Style: Ternaries instead of if statements
95d8983
@rianjs
Style: Null coalesce operator usage
2b54bda
@rianjs
Variable assignment is not used; join variable declaration and assign…
5e30487 
…ment where possible
@rianjs
Stop hiding indexer on IList
2e326b9
@rianjs
XML comment cleanup
ea251fd
@rianjs
Get base.Equals is reference equality when we really want false
2bd6722
@rianjs
Check for referential equality where appropriate
a93c7fb
@rianjs
Delete empty statements
71e86c3
@rianjs
Some expressions are always true -- no need for conditionals
61a7c2b
@rianjs
readonly fields where possible
14f22ae
@rianjs
Explicit private modifiers
cd0d7b4
@rianjs
Don't hide IList capabilities
625f07a
@rianjs
Proper use of ArgumentNullException
98d2bfe
@rianjs
Unused field values
ee55925
@rianjs
Unused method
8e83ce6
@rianjs
REBASE - Converting for to foreach
bf3a62e
@rianjs
Foreach usage where appropriate, except in RecurrencePatternEvaluator
7d20040 
which should be converted to set operations
@rianjs
More specific variable type leads to better linq expression
f6cc43b
@rianjs
Join declaration and assignment
29e3f77
@rianjs
Variable declarations closer to their usage
40949c8
@rianjs
Converting loops to LINQ expressions where possible
73388a0
@rianjs
UtcOffset's CopyFrom isn't used anywhere, but is referenced textually…
ab31682 
… by the NodaDateTime implementations which are themselves unused
@rianjs
Loops to LINQ where possible
a3ba9b3
@rianjs
LINQ queries to simplify loops where possible/readable
24091b5
@rianjs
Convert a nested loop to a single loop
be81810
@rianjs
Turns out EvaluateRDate was a noop that actually introduced a bug whe…
08a6802 
…n turned into not-a-noop
@rianjs
Delete commented-out code
3894a22
@rianjs
Ensure we don't enumerate the IEnumerable more than once
feded90
@rianjs
Non-accessed fields and variable cleanup
25808c3
@rianjs
Delete redundant code
4c40b87
rianjs added 17 commits May 30, 2016 09:35
@rianjs
Join assignment and declaration
0ed075a
@rianjs
Don't hide outer component
064d269
@rianjs
More stable hash functions. CalendarObject probably needs work
ab48439
@rianjs
Slightly better null handling in some places, more LINQ usage
f9c5d78
@rianjs
Null propagation operators and some null coalescing
bc5badb
@rianjs
Expression body instead of method body
7ebaa9f
@rianjs
Protected constructors in abstract classes
d9e27bf
@rianjs
More null propagation operators and coalescing
a2702f4
@rianjs
Specify string comparison semantics
62b80ca
@rianjs
Unused methods and classes
da5c1ea
@rianjs
Misc cleanup and reformatting
135ca68
@rianjs
Object and collection initializer
3fb3561
@rianjs
String interpolation and builders
d5edeea
@rianjs
Inverting if statements, misc cleanup
5ad4a35
@rianjs
Instantiating new managed Thread objects in unit tests isn't necessary
6d5916c
@rianjs
Add default collection size for all array-backed collections to avoid…
85bca8b 
… realloc+gc overhead
@rianjs
Another unnecessary using statement
0eae2b4
@rianjs rianjs merged commit 262547c into master May 30, 2016
@rianjs rianjs deleted the Cleanup branch May 30, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rianjs