FIX BUG: Stop adding referenceDate to results when at least one RRule is defined #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed a few things based on the following premises:
Not adding referenceDate to the results set at the start allows the rest of the logic to run normally and only add that date if it's part of the reccurenceRule. It will still be added to the results if the element has no recurrenceRule defined.
Theses modifications make issue #432 more predictable by returning the same results on the first day and subsequent days which are in the RRule. A slightly modified version of the code provided from that issue has been added to the unit tests.