Recurrence evaluation: Fix calculation of week numbering. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #652 +/- ##
===================================
Coverage 60% 60%
===================================
Files 100 100
Lines 4641 4643 +2
Branches 1104 1103 -1
===================================
+ Hits 2795 2797 +2
Misses 1379 1379
Partials 467 467
|
8 tasks
axunonb
force-pushed
the
work/minichma/bugfix/recur_test_restore
branch
from
e2d2355 to
5e2864e
Compare
|
axunonb
reviewed
Nov 25, 2024
axunonb
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore and fix one of the failing tests from #618. I.e. week numbers were not calculated correctly if the start of the week (
WKST) was different from Monday.