Recurrence evaluation: Implement support for negative BYWEEKNO values.
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IL=20170101T000000Z` and associated test failure.
8 tasks
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #654 +/- ##
===================================
Coverage 60% 60%
===================================
Files 100 100
Lines 4643 4657 +14
Branches 1103 1106 +3
===================================
+ Hits 2797 2811 +14
Misses 1379 1379
Partials 467 467
|
minichma
force-pushed
the
work/minichma/bugfix/recur_weekno
branch
from
2bd69c4 to
f7697a3
Compare
|
8 tasks
axunonb
reviewed
Nov 27, 2024
| // The last week of the year is the week that contains the 4th-last day of the year (which is the 28th of December in Gregorian Calendar). | ||
| var testTime = new DateTime(year + 1, 1, 1, 0, 0, 0, DateTimeKind.Unspecified).AddDays(-4); | ||
| return calendar.GetIso8601WeekOfYear(testTime, firstDayOfWeek); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for negative values in the
BYWEEKNOarray, like in the following example that is mentioned in #618.RRULE:FREQ=YEARLY;BYWEEKNO=1,2,-1,-2;BYDAY=TU;UNTIL=20170101T000000ZThis fixes the corresponding task in #618.