Reproduce and fix issues related to RECURRENCE-ID
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #659 +/- ##
===================================
Coverage 61% 61%
===================================
Files 99 99
Lines 4559 4561 +2
Branches 1083 1085 +2
===================================
+ Hits 2791 2801 +10
+ Misses 1302 1296 -6
+ Partials 466 464 -2
|
axunonb
reviewed
Dec 1, 2024
axunonb
reviewed
Dec 1, 2024
…to `RECURRENCE-ID`
…date/time, not only to the date.
…ences that replace others from the result set, we missed those outside the observed range, which is fixed by this change.
…t), which was lost due to prior code optimizations.
minichma
force-pushed
the
work/minichma/bugfix/recurrence-id
branch
from
79cb5b3 to
287fcfc
Compare
|
|
Thank you for the review! |
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the handling of
RECURRENCE-IDand by doing so fixes two bugs:RECURRENCE-IDand therefore replace others was constructed from the result set insideGetOccurrences. So if they were lying outside the observed range, they were missed, which could cause incorrect result sets.