Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor folding improvements #701

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Minor folding improvements #701

merged 1 commit into from
Jan 21, 2025

Conversation

ssratkevich
Copy link
Contributor

@ssratkevich ssratkevich commented Jan 21, 2025 •
edited by axunonb
Loading

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ssratkevich ssratkevich mentioned this pull request Jan 21, 2025
Closed
@axunonb axunonb changed the title Minor folding fixes Minor folding improvements Jan 21, 2025
@axunonb
Copy link
Collaborator

axunonb commented Jan 21, 2025

Beautiful, thanks. Agree with ReadOnlySpan. You're right, the buffer was 1 byte bigger than required.
Are you using the current v5 main branch (or daily build) or are you still on v4.3.1?

@axunonb axunonb merged commit 9da55cc into ical-org:main Jan 21, 2025
4 checks passed
@ssratkevich
Copy link
Contributor Author

Are you using the current v5 main branch (or daily build) or are you still on v4.3.1?

For now I just search a good free to use package for working with a iCal calendars as states at RFC-5545.

@ssratkevich ssratkevich deleted the 700-minor-folding-fixes branch January 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axunonb axunonb axunonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Folding improvements
2 participants
@ssratkevich @axunonb