Disallow initializing CalDateTime from DateTimeKind.Local and some cleanup
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #704 +/- ##
===================================
Coverage 65% 65%
===================================
Files 103 103
Lines 4660 4658 -2
Branches 1119 1128 +9
===================================
+ Hits 3025 3027 +2
+ Misses 1203 1198 -5
- Partials 432 433 +1
|
axunonb
reviewed
Jan 23, 2025
axunonb
reviewed
Jan 23, 2025
axunonb
reviewed
Jan 23, 2025
axunonb
reviewed
Jan 23, 2025
| } | ||
|
|
||
| public abstract IEnumerable<Period> Evaluate(IDateTime referenceDate, DateTime? periodStart, DateTime? periodEnd, bool includeReferenceDateInResults); | ||
| public abstract IEnumerable<Period> Evaluate(IDateTime referenceDate, IDateTime? periodStart, IDateTime? periodEnd, bool includeReferenceDateInResults); |
There was a problem hiding this comment.
nullable arguments should have #nullable enable. The effort shouldn't be too big? Otherwise I could just do that in another PR.
There was a problem hiding this comment.
Oh yes. It actually wasn't my intention to introduce nullable, but now that it's already there, I tried to enable #nullable for the affected files :-D I'm not using it too much, so please have a close look!
axunonb
reviewed
Jan 23, 2025
axunonb
reviewed
Jan 23, 2025
axunonb
reviewed
Jan 23, 2025
axunonb
previously approved these changes
Jan 23, 2025
…DateTime` to avoid ambiguity.
minichma
force-pushed
the
work/minichma/feature/evaluator_caldatetime
branch
from
b781cd3 to
3db7dea
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant efforts were made lately to reduce the ambiguity that comes from dealing with
System.DateTimewithDateTimeKind.Local. The latter refers to the system's local time zone, which is not something that ical.net is aware of and wants to deal with. This PR cleans up some of the remaining places whereDateTimeKind.Localcould still appear and dissallows initializingCalDateTimeinstances with aDateTimeof kindLocal.It also changes the parameters of
IEvaluator.Evaluate()fromSystem.DateTimetoIDateTimeto avoid ambiguity and does some other minor cleanup.Fixes #406