Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CalendarEvent.EffectiveDuration and some conversion functions public. #733

Merged
merged 2 commits into from
Feb 16, 2025

Make conversion methods between `Duration` and `TimeStamp` public.

e13dcbe
Select commit
Loading
Failed to load commit list.
Merged

Make CalendarEvent.EffectiveDuration and some conversion functions public. #733

Make conversion methods between `Duration` and `TimeStamp` public.
e13dcbe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 15, 2025 in 1s

66% (target 80%)

View this Pull Request on Codecov

66% (target 80%)

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/CalendarComponents/CalendarEvent.cs 78% 1 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (66%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #733   +/-   ##
===================================
  Coverage    66%    66%           
===================================
  Files       103    103           
  Lines      4644   4645    +1     
  Branches   1152   1152           
===================================
+ Hits       3064   3065    +1     
  Misses     1144   1144           
  Partials    436    436
Files with missing lines Coverage Δ
Ical.Net/DataTypes/CalDateTime.cs 90% <100%> (ø)
Ical.Net/DataTypes/Duration.cs 77% <100%> (+<1%) ⬆️
Ical.Net/Evaluation/EventEvaluator.cs 88% <100%> (ø)
Ical.Net/CalendarComponents/CalendarEvent.cs 74% <78%> (ø)
View more details on Codecov