-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect handling of UNTIL if falling into DST change and some related improvements #738
base: main
Are you sure you want to change the base?
Conversation
…and to avoid expensive timezone operations.
…me` which can easily be confusing and error prone.
…s with DST changes.
77a049e
to
124cb51
Compare
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (75%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #738 +/- ##
===================================
- Coverage 66% 66% -0%
===================================
Files 105 105
Lines 4649 4633 -16
Branches 1151 1144 -7
===================================
- Hits 3073 3054 -19
+ Misses 1142 1139 -3
- Partials 434 440 +6
|
Reproduce and fix #736. I.e. if
UNTIL
falls into a DST change with ambiguity, then recurrences could have missed, which is fixed with this PR.Other improvements include:
System.DateTime
toCalDateTime
, which could cause confusion and was a source of bugs.AsUtc
fromCalDateTime.GetHashCode()
to avoid timezone calculationsCalDateTime
if they have the sameTzId