Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Occurrence#overnight? did not work for start times on the last day of a month #218

Merged
merged 1 commit into from
Mar 21, 2014

Conversation

neckhair
Copy link
Contributor

When the overnight? method was called on an occurrence with a start time on the last day of a month, it threw an argument out of range exception.

[1] pry(main)> occurrence = IceCube::Occurrence.new Time.new(2014, 3, 31)
=> 2014-03-31 00:00:00 +0200
[2] pry(main)> occurrence.overnight?
ArgumentError: argument out of range
from /Users/phil/.rvm/gems/ruby-2.0.0-p353@iq/gems/ice_cube-0.11.3/lib/ice_cube/occurrence.rb:96:in `initialize'

avit added a commit that referenced this pull request Mar 21, 2014
Fix: Occurrence#overnight? on the last day of a month
@avit avit merged commit e673f35 into ice-cube-ruby:master Mar 21, 2014
@avit
Copy link
Collaborator

avit commented Mar 21, 2014

Thanks! Good catch.

@neckhair
Copy link
Contributor Author

neckhair commented Apr 4, 2014

@avit Would you mind releasing this? So we can use the original gem again, instead of our fork or your master. (I have to close my own issue ;-)

@avit
Copy link
Collaborator

avit commented Apr 6, 2014

@neckhair thanks for your contribution, 0.12.0 is released now.

(Please see the UPGRADING file for something to be aware of as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants