-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always increment quad, mesh, text and image layer counts in wgpu layer rendering #2701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just hit this bug. Pesky one!
Thanks 🙇
In fact, I believe we can just avoid preparing these layers altogether as a simpler fix: |
@hecrj These changes apparently broke the ![]() Notice how the text is clipped to the viewport of the custom widget, but the rectangles are drawn outside the widget, on top of the buttons. Latest master with changes from this PR reverted: ![]() The widget code is here: https://github.com/syndicodefront/infekt/blob/3f15caa6fdc8aa381422a5a28340984de589fbb4/infekt-v2/src/gui/widget/enhanced_nfo_view.rs#L231 Am I abusing a bug here as a feature or is it a regression? |
It seems like the changes made here were later refactored in 3428a3d, could that commit also be affecting things? I honestly have no idea. |
At first glance, the replacement of |
@hecrj confirming it works, much appreciated! |
Fixes #2700