Power prefference patch #2813
Open
Power prefference patch #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far tested it on windows, and Linux desktop. Both resulted in PowerPrefference being set to high, which is the desired outcome. |
Comment on lines
+90
to
+92
| let output = Command::new("cat") | ||
| .arg("/sys/class/dmi/id/chassis_type") | ||
| .output(); |
There was a problem hiding this comment.
is there a reason to call out to cat instead of normal fs io?
There was a problem hiding this comment.
No, not really. I just used shell on windows, and decided to use it on Linux as well just for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue mentioned in #2810. Currently I'm doing so by looking at the reported chassis type on Linux, and requesting pc system type enum for windows, to determine if the device is low powered, or high powered. In the cases of platform not being either of them it defaults to Low Power, which shouldn't matter in case of Macs, and is a logical default in my head for an unknown OS.