This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Fix avro serialize #261
Merged
Fix avro serialize #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase main branch and try again. cc @ZENOTME |
We need sync avro with main (to get the fix of custom attribute in RecordField) and an extra commit to fix list and map🥵. |
added 2 commits
January 12, 2024 16:04
| @@ -11,7 +11,7 @@ resolver = "2" | |||
| anyhow = "1" | |||
| async-trait = "0.1" | |||
| # branch is icelake-dev | |||
| apache-avro = { git = "https://github.com/icelake-io/avro.git", rev = "4866a4ad0ed5d6af7160c9b52af898ab6d0551f9", features = ["derive"] } | |||
There was a problem hiding this comment.
Please use rev to pin to a version, otherwise downstream project maybe affected when we push changes to branch.
| con1 = t1.scan().to_duckdb(table_name="t1") | ||
| con2 = t2.scan().to_duckdb(table_name="t2") | ||
|
|
||
| res1 = con1.execute("SELECT * from t1").fetchall() |
There was a problem hiding this comment.
Should we consider add order by here to ensure correctness?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.