feat(module): scaffold parameters for a module #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
reviewed
Oct 26, 2021
starport/templates/module/create/stargate/proto/{{moduleName}}/genesis.proto.plush
Outdated
Show resolved
Hide resolved
starport/templates/module/create/stargate/x/{{moduleName}}/client/cli/query_params.go.plush
Outdated
Show resolved
Hide resolved
starport/templates/module/create/stargate/x/{{moduleName}}/types/params.go.plush
Show resolved
Hide resolved
lumtis
approved these changes
Oct 28, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* add params structure * add missing params file * add testutil/keeper * add integration test for params * fix ibc testutil keeper * add params test for ibc * use types.DefaultParams for TestParamsQuery * fix identantion for plush files * add param tests for keeper * fix subspace not found * fix unused todo var * fix param subspace for testutil * fix unused import for module without params * fix condition with wrong syntax * fix integration test collision * fix dummy value index * fix dummy ValueInvalidIndex * value index should be a string not a number * prevent unused import error cor strconv * avoid use strconv for string params types * fix param index for the genesis state and some comments * add bool param into the integration test * improve todo comment for default value Co-authored-by: İlker G. Öztürk <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1699
What does this PR?
Add in the starport s module command the flag --params that allow specifying the param fields of the module.
How to test?