Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move road placement logic directly to the map format #9590

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Feb 23, 2025

relates to #8589

Things to do:

  • fix road placement in some cases as it leads to bizarre results
  • move terrain placement logic to map format and remove saveMapInEditor() function completely

@ihhub ihhub added improvement New feature, request or improvement editor Map editor related stuff labels Feb 23, 2025
@ihhub ihhub self-assigned this Feb 23, 2025
@ihhub ihhub marked this pull request as draft February 23, 2025 09:26
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link

@ihhub
Copy link
Owner Author

ihhub commented Feb 23, 2025

Hi @Districh-ru , could you please take a look at the wrong road placement? I am not sure what is going on.

@ihhub
Copy link
Owner Author

ihhub commented Feb 23, 2025

@Districh-ru , also I noticed that we still put terrain via Maps::Tiles and then save the info inside MapFormat. This leads to a fact that road placement does not properly update terrain but let's fix roads first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant