Fix the logic of transferring artifacts after a battle

[oleg-derevenetz]

fix #9592

If I understood correctly, this is exactly how it should work. Here is a video of the artifact transfer process (the source has been modified a bit to allow the artifact transfer on retreat or surrender):

fheroes2.engine.version_.1.1.6.2025-02-24.23-28-59.mp4

[zenseii]

@oleg-derevenetz . The logic looka correct apart from the transfer of ultimate artifacts. From what I understand, the UA will never leave the defeated hero, right @LeHerosInconnu ?

Meanwhile, I'm aware that in the original game the winning hero gets an empty inventory slot per UA on the defeated hero but this seems strange to me, which means that items are skipped. I'll ask for people's opinion on it in the issue thread.

[oleg-derevenetz]

From what I understand, the UA will never leave the defeated hero

According to my understanding, they either disappear or remain with the defeated hero. The winner never gets them. It works the same way here.

I'm aware that in the original game the winning hero gets an empty inventory slot per UA on the defeated hero but this seems strange to me, which means that items are skipped.

Well, in this PR, empty slots for UA also remain in the winner's bag, just at the end, not in the middle. I don't think it's essential.

[zenseii]

According to my understanding, they either disappear or remain with the defeated hero. The winner never gets them. It works the same way here.

I've tested this now and can confirm that in the case when a UA is attempted to be transferred when there's space in the winning hero's inventory, it will disappear from the losing hero's inventory too.

[LeHerosInconnu]

Hello @zenseii and @oleg-derevenetz,

Here is a video of the artifact transfer process (the source has been modified a bit to allow the artifact transfer on retreat or surrender):

It's only for demonstration purposes, right? :)

@oleg-derevenetz . The logic looka correct apart from the transfer of ultimate artifacts. From what I understand, the UA will never leave the defeated hero, right @LeHerosInconnu ?

If the victorious hero has a free slot in his inventory, he tries to grab the ultimate artifact, but it disappears as soon as he tries.
The defeated hero retains an ultimate artifact only if the winning hero doesn't try to grab it, i.e. when his inventory no longer has a free slot to capture, or try to capture, the next artifact in the defeated hero's inventory.

Meanwhile, I'm aware that in the original game the winning hero gets an empty inventory slot per UA on the defeated hero but this seems strange to me, which means that items are skipped. I'll ask for people's opinion on it in the issue thread.

Yes, it's weird and doesn't really make sense.

[ihhub]

@oleg-derevenetz , a bunch of thanks for the fix!