Do not read past end of extra fields record when reading each extra field #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just amended this commit so that when an extra field is broken it is ignored and not added to the field list. hope this doesn't break anything. |
|
I think I'm happy to accept this pull request, given that any problems with this fix should show up pretty quickly upstream. I'd ideally like feedback from e.g. @kris-sigur or @ikreymer first though. |
nlevitt
pushed a commit
to nlevitt/webarchive-commons
that referenced
this pull request
Feb 28, 2014
Merge iipc into ia
anjackson
added a commit
that referenced
this pull request
Mar 6, 2014
Do not read past end of extra fields record when reading each extra field
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a good solution for #9 to me, let's see what Travis makes of it.