Escape redirect URLs in RealCDXExtractorOutput #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardgossen
force-pushed
the
master
branch
from
191ce78 to
363a3c5
Compare
|
This looks good. Can you also add a note to the CHANGES.md file that summarises the change? |
|
Updated CHANGES.md |
anjackson
added a commit
that referenced
this pull request
Dec 17, 2014
Escape redirect URLs in RealCDXExtractorOutput
|
Thanks, looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes does not escape the URLs it gets from the HTTP headers / the HTML meta tags. This makes the resulting CDX files invalid if the redirect URL contains spaces (see e.g. internetarchive/ia-hadoop-tools#4). This commit fixes that by passing the resolved URL through
java.net.URI's multi-argument constructor which escapes the individual parts appropriately.