Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMYK jpeg bug #203

Closed
lilith opened this issue Nov 1, 2018 · 8 comments
Closed

Fix CMYK jpeg bug #203

lilith opened this issue Nov 1, 2018 · 8 comments

Comments

@lilith
Copy link
Member

lilith commented Nov 1, 2018

See inactive failing test here:

//fn decode_cmyk_jpeg(){

@danieljuhl
Copy link

danieljuhl commented Nov 2, 2018

@lilith is this related to the underlaying issue mentioned in #188 ?

@lilith
Copy link
Member Author

lilith commented Nov 2, 2018

Yes.

@danieljuhl
Copy link

Any news on this? Anything I / we can do to make imageflow compatible with CMYK jpeg?

@danieljuhl
Copy link

Or at least avoid that imageflow server crashes on CMYK images.

@lilith
Copy link
Member Author

lilith commented Aug 25, 2019 via email

@danieljuhl
Copy link

How about catching the error, so the server does not crash on CMYK images? Is that an easier fix? :)

@kornelski
Copy link
Member

I think it's already trying to catch the error, it's just that catching doesn't work due to rust-lang/rfcs#2699

@lilith
Copy link
Member Author

lilith commented Apr 10, 2020

Turns out that setjmp was simply too late, it needed to be earlier. CMYK jpegs aren't supported but this is no longer a fatal error.

@lilith lilith closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants