-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMYK jpeg bug #203
Comments
Yes. |
Any news on this? Anything I / we can do to make imageflow compatible with CMYK jpeg? |
Or at least avoid that imageflow server crashes on CMYK images. |
It requires a whole new jpeg codec API (TurboJpeg) and adapter. Not an easy
fix.
…On Thu, Aug 22, 2019, 6:47 AM Daniel Juhl ***@***.***> wrote:
Or at least avoid that imageflow server crashes on CMYK images.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#203?email_source=notifications&email_token=AAA2LH6QLQUDN6I3KP6ESPDQF2DFHA5CNFSM4GBFLX4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4466UY#issuecomment-523890515>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA2LHYYYX4XHEQ4L6P5J5DQF2DFHANCNFSM4GBFLX4A>
.
|
How about catching the error, so the server does not crash on CMYK images? Is that an easier fix? :) |
I think it's already trying to catch the error, it's just that catching doesn't work due to rust-lang/rfcs#2699 |
Turns out that setjmp was simply too late, it needed to be earlier. CMYK jpegs aren't supported but this is no longer a fatal error. |
See inactive failing test here:
imageflow/imageflow_core/tests/visuals.rs
Line 387 in df49f42
The text was updated successfully, but these errors were encountered: