-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Logitech MX Ink #265
Conversation
Thank you for doing this so quickly! It should probably be none.glb handed rather than right.glb |
The pen is always surfaced as either left or right handed so I think this is correct. |
Could a user potentially have two, one in each hand? |
I don't think that is supported but I will ask |
Also, note that the user can still hold the regular controller in their other hand. |
I think it could still be "none" because it appears that the model is still the same between hands and the input profile. Is there some difference that means that we need to expose the handedness? It feels odd to me is all. |
The name in this directory corresponds with the "handedness" attribute of the inputSource. Since that will never be |
Ada is right: If it's the same mesh that's used in both hands you can upload it as 'none.glb' and specify in the JSON that it's used for either hand. It'll still come through with the appropriate handedness in-app. See the HTC Vive asset for an example of how this works. And yes, thanks for getting this up! |
This looks good to me! |
@AdaRoseCannon @toji note that the model still needs to be optimized in blender to show the animations and the correct default position. |
I think it can't find the path: ![]() I think you might need the override as described here: https://github.com/immersive-web/webxr-input-profiles/tree/601f7a2e0e6956ce431cf2e38c10b33e3e65eb34/packages/assets/tutorial#add-a-profilejson |
@cabanier I have prepared a model with the correct position and the buttons animations; but I am not sure which component is which button, apart from the obvious like @AdaRoseCannon the viewer can't find the path because by default it tries to load the left hand model; you just have to select |
Thank you so much! that is awesome.
Unfortunately, you need v69 of the OS and Browser 35.0 to get proper support. gamepad 0 = front button (close to tip) only click - needs animation |
Thanks for your rapid response @cabanier! I just made the PR #266. Just one thing, according to the profile: "gamepad": {
"mapping": "xr-standard",
"buttons": [
"xr-standard-trigger",
"xr-standard-squeeze",
null,
null,
"touch-pad",
"tip-force",
"docked"
],
"axes": []
} The Let me know if you find any errors and I'll update the model.
I am on v69 PTC but can't update the Browser to 35.0. Not sure if there's a program to access beta versions of the browser. |
Yes, my list had a typo. Sorry about that!
I can send you a private build to try. Are you on the WebXR Discord? If so, you can dm me there at @rc |
I was wrong, the model should appear no matter which handedness you choose in the viewer. The error appears because the left and right models aren't properly linked with the |
First pass at support for the MX Ink.
The model still needs to be opened in blender to adjust for the rest position and add the buttons names and animations.